Skip to content

Polishing #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
* @author Mark Paluch
* @author Johannes Englmeier
* @author Florian Cramer
* @author Yanming Zhou
*/
public class AnnotationRepositoryConfigurationSource extends RepositoryConfigurationSourceSupport {

Expand All @@ -68,8 +69,6 @@ public class AnnotationRepositoryConfigurationSource extends RepositoryConfigura
private final AnnotationMetadata enableAnnotationMetadata;
private final AnnotationAttributes attributes;
private final ResourceLoader resourceLoader;
private final Environment environment;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are fine.

private final BeanDefinitionRegistry registry;
private final boolean hasExplicitFilters;

/**
Expand Down Expand Up @@ -121,8 +120,6 @@ public AnnotationRepositoryConfigurationSource(AnnotationMetadata metadata, Clas
this.enableAnnotationMetadata = AnnotationMetadata.introspect(annotation);
this.configMetadata = metadata;
this.resourceLoader = resourceLoader;
this.environment = environment;
this.registry = registry;
this.hasExplicitFilters = hasExplicitFilters(attributes);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,13 @@
* @author Thomas Darimont
* @author Peter Rietzler
* @author Jens Schauder
* @author Yanming Zhou
*/
public abstract class RepositoryConfigurationSourceSupport implements RepositoryConfigurationSource {

protected static final String DEFAULT_REPOSITORY_IMPL_POSTFIX = "Impl";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't because we do not want to alter visibility.


private final Environment environment;
protected final Environment environment;
private final RepositoryBeanNameGenerator beanNameGenerator;
private final BeanDefinitionRegistry registry;
protected final BeanDefinitionRegistry registry;

/**
* Creates a new {@link RepositoryConfigurationSourceSupport} with the given environment.
Expand Down Expand Up @@ -117,7 +116,7 @@ public ImplementationDetectionConfiguration toImplementationDetectionConfigurati
return new SpringImplementationDetectionConfiguration(this, factory);
}

private class SpringImplementationDetectionConfiguration implements ImplementationDetectionConfiguration {
private static class SpringImplementationDetectionConfiguration implements ImplementationDetectionConfiguration {

private final RepositoryConfigurationSource source;
private final MetadataReaderFactory metadataReaderFactory;
Expand Down