DATACMNS-1303: Change two method names. #288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two methods are adding given events to the "domainEvents", so that their names should be "add***" but not "and***".
|
Please create a ticket in our issue tracker so we can understand, what exactly you want to achieve. For this change, I don't think this is going to happen as the change breaks compatibility. |
Kui-Liu
changed the title
Kui-Liu
changed the title
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
|
Since the API is now public we cannot change the method names anymore. We keep DATACMNS-1303 open for revisiting the topic for Spring Data 3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two methods are adding given events to the "domainEvents", so that their names should be "add***" but not "and***".