Skip to content

Make the all args Order constructor public #2823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Make the all args Order constructor public #2823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87180c8
order-constructor - Prepare branch
schauder Apr 27, 2023
0c56286
Make all args Order constructor public.
schauder Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<groupId>org.springframework.data</groupId>
<artifactId>spring-data-commons</artifactId>
<version>3.1.0-SNAPSHOT</version>
<version>3.1.0-order-constructor-SNAPSHOT</version>

<name>Spring Data Core</name>
<description>Core Spring concepts underpinning every Spring Data module.</description>
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/org/springframework/data/domain/Sort.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ public static enum NullHandling {
*
* @author Oliver Gierke
* @author Kevin Raymond
* @author Jens Schauder
*/
public static class Order implements Serializable {

Expand Down Expand Up @@ -434,7 +435,7 @@ public static Order desc(String property) {
* @param nullHandling must not be {@literal null}.
* @since 1.7
*/
private Order(@Nullable Direction direction, String property, boolean ignoreCase, NullHandling nullHandling) {
public Order(@Nullable Direction direction, String property, boolean ignoreCase, NullHandling nullHandling) {

if (!StringUtils.hasText(property)) {
throw new IllegalArgumentException("Property must not be null or empty");
Expand Down