DATACMNS-1259 - Fixed support for Long values in Auditables. #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Instant as internal data type since it's a point in time without time zone which LocalDateTime isn't. Added necessary converters. Fixed one JodaTime converter that used UTC to use SystemDefault like other similar converters. In case of a conversion failure the error message now contains the source type.
Refactored lambdas to method references. Simplified type parameter. Added comment to test to indicate related issue.
odrotbohm
pushed a commit
that referenced
this pull request
Feb 16, 2018
Using Instant as internal data type since it's a point in time without time zone which LocalDateTime isn't. Added necessary converters. Fixed one JodaTime converter that used UTC to use SystemDefault like other similar converters. In case of a conversion failure the error message now contains the source type. Original pull request: #273.
odrotbohm
pushed a commit
that referenced
this pull request
Feb 16, 2018
Refactored lambdas to method references. Simplified type parameter. Added comment to test to indicate related issue. Original pull request: #273.
odrotbohm
added a commit
that referenced
this pull request
Feb 16, 2018
Removed unnecessary imports. Tiny refactoring to pull exception creation into static helper method. Made methods static in test cases where possible. Original pull request: #273.
odrotbohm
pushed a commit
that referenced
this pull request
Feb 16, 2018
Using Instant as internal data type since it's a point in time without time zone which LocalDateTime isn't. Added necessary converters. Fixed one JodaTime converter that used UTC to use SystemDefault like other similar converters. In case of a conversion failure the error message now contains the source type. Original pull request: #273.
odrotbohm
pushed a commit
that referenced
this pull request
Feb 16, 2018
Refactored lambdas to method references. Simplified type parameter. Added comment to test to indicate related issue. Original pull request: #273.
odrotbohm
added a commit
that referenced
this pull request
Feb 16, 2018
Removed unnecessary imports. Tiny refactoring to pull exception creation into static helper method. Made methods static in test cases where possible. Original pull request: #273.
|
I am puzzled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Instant as internal data type since it's a point in time without time zone which LocalDateTime isn't.
Added necessary converters.
Fixed one JodaTime converter that used UTC to use SystemDefault like other similar converters.
In case of a conversion failure, the error message now contains the source type.