Skip to content

Consider repository bean name for custom implementation and fragment bean names. #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented Oct 22, 2021

We now consider the repository bean name when checking for existing bean definitions of default custom implementation beans. Previously, we used the repository interface name without considering the repository bean name.

We also now consider the actual bean name when registering custom implementations and repository fragments after falling back to component scan mode. Previously we derived the bean name either from the repository bean name or the class name.

@mp911de mp911de added the type: regression A regression from a previous release label Oct 22, 2021
@mp911de mp911de linked an issue Oct 22, 2021 that may be closed by this pull request
@mp911de mp911de requested a review from odrotbohm October 22, 2021 11:42
@odrotbohm odrotbohm force-pushed the main branch 2 times, most recently from c08d207 to 2a1a8f3 Compare June 13, 2022 14:04
@mp911de mp911de assigned christophstrobl and unassigned odrotbohm Aug 24, 2022
…bean name.

We now consider the repository bean name when checking for existing bean definitions of default custom implementation beans. Previously, we used the repository interface name without considering the repository bean name.

Closes #2487.
…registration.

We now consider the actual bean name when registering custom implementations and repository fragments after falling back to component scan mode. Previously we derived the bean name either from the repository bean name or the class name.

Closes #2487.
christophstrobl pushed a commit that referenced this pull request Oct 12, 2022
…registration.

We now consider the the actual repository & fragment bean name when checking for existing bean definitions of default custom implementation beans. Previously, we used the repository interface name without considering the repository bean name.

Closes #2487.
Original Pull Request: #2488
christophstrobl added a commit that referenced this pull request Oct 12, 2022
Update exception messages, align method names, extract methods
Original Pull Request: #2488
@mp911de mp911de deleted the issue/2487 branch March 6, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A regression from a previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolution of ambiguous implementations does not work
3 participants