Deprecate ChainedTransactionManager #2286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recommend to not use ChainedTransactionManager as it emulates distributed transactions without providing consistency guarantees that can end up in partially committed transactions. To attach to commit/rollback operations we recommend registering TransactionSynchronization instead. See #2232.
mp911de
requested review from
christophstrobl,
gregturn,
jxblum,
odrotbohm and
schauder
mp911de
added
the
for: team-attention
schauder
approved these changes
Jan 29, 2021
christophstrobl
pushed a commit
that referenced
this pull request
Feb 2, 2021
We recommend to not use ChainedTransactionManager as it emulates distributed transactions without providing consistency guarantees that can end up in partially committed transactions. To attach to commit/rollback operations we recommend registering TransactionSynchronization instead. Closes #2232 Original Pull Request: #2286
OrangeDog
reviewed
May 25, 2021
| * <p/> | ||
| * Instead of using {@link ChainedTransactionManager} for attaching callbacks to transaction commit (pre commit/post | ||
| * commit), either register a {@link org.springframework.transaction.reactive.TransactionSynchronization} to explicitly | ||
| * follow transaction cleanup with simplified semantics in case of exceptions. |
There was a problem hiding this comment.
This "either" seems to be missing an "or".
|
This didn't make it into the release notes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recommend to not use
ChainedTransactionManageras it emulates distributed transactions without providing consistency guarantees that can end up in partially committed transactions. To attach to commit/rollback operations we recommend registeringTransactionSynchronizationinstead.Closes #2232.