DATACMNS-976 - AbstractEntityInformation considers Persistable.isNew().

pom.xml

@@ -5,7 +5,7 @@
 
 	<groupId>org.springframework.data</groupId>
 	<artifactId>spring-data-commons</artifactId>
-	<version>1.13.0.BUILD-SNAPSHOT</version>
+	<version>1.13.0.DATACMNS-976-SNAPSHOT</version>
 
 	<name>Spring Data Core</name>
 

src/main/java/org/springframework/data/repository/core/support/AbstractEntityInformation.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2011-2013 the original author or authors.
+ * Copyright 2011-2017 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,6 +17,7 @@
 
 import java.io.Serializable;
 
+import org.springframework.data.domain.Persistable;
 import org.springframework.data.repository.core.EntityInformation;
 import org.springframework.util.Assert;
 
@@ -26,6 +27,7 @@
  * 
  * @author Oliver Gierke
  * @author Nick Williams
+ * @author Christoph Strobl
  */
 public abstract class AbstractEntityInformation<T, ID extends Serializable> implements EntityInformation<T, ID> {
 
@@ -48,6 +50,10 @@ public AbstractEntityInformation(Class<T> domainClass) {
 	 */
 	public boolean isNew(T entity) {
 
+		if(entity instanceof Persistable) {
+			return ((Persistable) entity).isNew();
+		}
+
 		ID id = getId(entity);
 		Class<ID> idType = getIdType();
 

src/test/java/org/springframework/data/repository/core/support/AbstractEntityInformationUnitTests.java

@@ -18,12 +18,15 @@
 import static org.hamcrest.CoreMatchers.*;
 import static org.junit.Assert.*;
 
+import lombok.Builder;
+
 import java.io.Serializable;
 
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
 import org.springframework.data.annotation.Id;
+import org.springframework.data.domain.Persistable;
 import org.springframework.data.repository.core.EntityInformation;
 import org.springframework.test.util.ReflectionTestUtils;
 import org.springframework.util.ReflectionUtils;
@@ -33,6 +36,7 @@
  * 
  * @author Oliver Gierke
  * @author Nick Williams
+ * @author Christoph Strobl
  */
 public class AbstractEntityInformationUnitTests {
 
@@ -88,6 +92,17 @@ public void rejectsUnsupportedPrimitiveIdType() {
 		information.isNew(new UnsupportedPrimitiveIdEntity());
 	}
 
+	@Test // DATACMNS-976
+	public void considersPersistableIsNew() {
+
+		FooEn<ImplementingPersistable, String> information = new FooEn<ImplementingPersistable, String>(ImplementingPersistable.class);
+
+		assertThat(information.isNew(ImplementingPersistable.builder().id(100L).isNew(true).build()), is(true));
+		assertThat(information.isNew(ImplementingPersistable.builder().isNew(true).build()), is(true));
+		assertThat(information.isNew(ImplementingPersistable.builder().id(100L).isNew(false).build()), is(false));
+		assertThat(information.isNew(ImplementingPersistable.builder().isNew(false).build()), is(false));
+	}
+
 	static class PrimitiveIdEntity {
 
 		@Id long id;
@@ -124,4 +139,21 @@ public Class<ID> getIdType() {
 			return (Class<ID>) ReflectionUtils.findField(type, "id").getType();
 		}
 	}
+
+	@Builder
+	static class ImplementingPersistable implements Persistable<Long> {
+
+		final Long id;
+		final boolean isNew;
+
+		@Override
+		public Long getId() {
+			return id;
+		}
+
+		@Override
+		public boolean isNew() {
+			return isNew;
+		}
+	}
 }