I'd Like a Two-argument Constructor for `PageImpl`

[Attacktive]

I'm sorry if it's already been discussed.

We currently have two options:

spring-data-commons/src/main/java/org/springframework/data/domain/PageImpl.java

Lines 47 to 55 in 2760cb9

	public PageImpl(List<T> content, Pageable pageable, long total) {
	super(content, pageable);
	this.total = pageable.toOptional().filter(it -> !content.isEmpty())//
	.filter(it -> it.getOffset() + it.getPageSize() > total)//
	.map(it -> it.getOffset() + content.size())//
	.orElse(total);
	}

spring-data-commons/src/main/java/org/springframework/data/domain/PageImpl.java

Lines 63 to 65 in 2760cb9

	public PageImpl(List<T> content) {
	this(content, Pageable.unpaged(), CollectionUtils.isEmpty(content) ? 0 : content.size());
	}

I think it's common to want a constructor with List<T> content and Pageable pageable:

public PageImpl(List<T> content, Pageable pageable) {
	this(content, pageable, CollectionUtils.isEmpty(content) ? 0 : content.size());
}

I just gave my two cents.

[mp911de]

The path difference between a two-args and three-args constructor where inferring the size is minimal. Generally, a content list must not be null hence it is safe to always call the size method on your side. We don't have much usage for an additional constructor here and so we would rather not include such a change.