Skip to content

Redunant code in DefaultEntityCallbacks#callback #3055

Closed
@mawen12

Description

@mawen12

I have found org.springframework.data.mapping.callback.DefaultEntityCallbacks#callback method exists redunant code.

entity is checked not null, then don't need to call callbackDiscoverer.resolveDeclaredEntityType(callbackType).getRawClass()).

current code:

@Override
public <T> T callback(Class<? extends EntityCallback> callbackType, T entity, Object... args) {
    // check entity not null
    Assert.notNull(entity, "Entity must not be null");
    // redundant code
    Class<T> entityType = (Class<T>) (entity != null ? ClassUtils.getUserClass(entity.getClass())
		: callbackDiscoverer.resolveDeclaredEntityType(callbackType).getRawClass());
    ......
}

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions