Registration of custom converters [DATACMNS-1307]

[spring-projects-issues]

James Green opened DATACMNS-1307 and commented

Apologies if this is already recorded but I would have saved a lot of time from #820 if I had not needed to implement a custom redisCustomConversions and instead been able to inject this with my code and added to it at run-time.

I spotted the @ReadingConverter annotation and without reading any further expected this to be scanned for and included. Then, realised no such magic occurred and still further realised there was no redisCustomConversions for autowiring (according to IntelliJ, at least) and thus a full bean override was needed.

The JMS integration works with a bunch of message converters, perhaps the Redis side could adopt the same or use this as the basis?

---

No further details from DATACMNS-1307

[spring-projects-issues]

Mark Paluch commented

Thanks for raising this issue. The reason we can't simply register and pick up converters is that we'd run into ambiguity. Reading and writing converters via CustomConversions is a Spring Data concept that is shared across Data-store specific modules. If we'd pickup and register converters, this conversion would be applied to all Spring Data modules that are in use regardless whether that's intended or not.

In contrast, Spring JMS support, is unique in its API so it doesn't create ambiguity.

 

See also our documentation which mentions the need for custom registration

[spring-projects-issues]

Mark Paluch commented

Moved to Spring Data Commons as that's a concern touching various store modules