Skip to content

#369 - Add Kotlin property and plugin to build parent. #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

resolves #369

Copy link
Member

@odrotbohm odrotbohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kind of wondering what the implications of this are for projects that don't add any Kotlin extensions currently. Do they still compile as expected? Does the IDE setup create issues?

@christophstrobl
Copy link
Member Author

@olivergierke everything seems to work just fine even after adding the plugin. The step is just skipped when there's no src/main/kotlin directory available. Maybe @sdeleuze can have a look at this one as well.

@sdeleuze
Copy link
Contributor

Even if the syntax is verbose, this is to me the right way to support mixed Kotlin + Java project with maven indeed and that should not cause any issue in IDEs (already widely used by a lot of developers). In case we detect something, Kotlin team is quite responsive to our issue reports.

odrotbohm pushed a commit that referenced this pull request Jun 21, 2017
odrotbohm added a commit that referenced this pull request Jun 21, 2017
@odrotbohm odrotbohm closed this Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kotlin properties and plugins to parent/pom.xml
3 participants