Rename HCP to SAP_CLOUD_PLATFORM, as it is the official name. #9747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
What changed your mind since you opened the original pull request? I appreciate the use of official name but |
snicoll
added
the
status: waiting-for-feedback
|
@snicoll Hana Cloud Platform (HCP) is not the official name anylonger, so I wanted to adopt this here, as this is still in milestone state (and not released). Any suggestions for a shorter name? |
|
|
|
Sounds reasonable, I will update the PR. |
|
@ihrigb if you do, please only change that then. Your PR has a lot of unrelated changes. Thank you. |
|
Damn, used the wrong formatter... I will try to fix it. |
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Jul 13, 2017
snicoll
added a commit
that referenced
this pull request
Jul 13, 2017
* pr/9747: Polish "Rename HCP to SAP" Rename HCP to SAP
|
That was better but still too much unrelated changes. I've polished them myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename HCP to SAP_CLOUD_PLATFORM, as this is the official name of the platform.