Support getting environment from other events. #7066
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@youngm Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@youngm Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
youngm
force-pushed
the
pidotherevents
branch
2 times, most recently
from
3afe8a3 to
8d9f154
Compare
|
I'm not too keen on the reflection route, it seems a bit brittle. I'd probably rather add the explicit event types that we want to support. |
philwebb
added
status: waiting-for-feedback
youngm
force-pushed
the
pidotherevents
branch
from
8d9f154 to
ebbcedb
Compare
|
PR Updated. |
youngm
force-pushed
the
pidotherevents
branch
from
ebbcedb to
1a57632
Compare
philwebb
added
status: feedback-provided
philwebb
added a commit
that referenced
this pull request
Oct 31, 2016
* pr/7066: Support ApplicationReadyEvent from PidFileWriter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Issue: #7027
This PR supports using Environment properties from any event that provide a "getApplicationContext()" method. It also changes existing functionality to log a warning if Environment properties are not used (would have been useful in my debugging of the issue).
After writing the code I realized that the Ready is probably the only other useful event that currently exists that someone might want to use that provides Environment properties. If you'd prefer for me to change the PR to only add support for
Readyand/or not log a warning let me know and I can update the PR to do that.