-
Notifications
You must be signed in to change notification settings - Fork 41.2k
upgrade elasticsearch to 2.2.0 #5511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@htynkn I know I've asked before, but can you confirm that you've signed the CLA. |
@philwebb Yes, my confirmation number is 128120150629030655. |
I wonder if we couldn't provide a default temp directory location for this new property rather than requiring the user to provide it. I am not sure what was happening before 2.2 (no persistence maybe?) |
@snicoll it started from elasticsearch 2.0 as mandatory field so we are asking user to specify there they want elasticsearch to start in local environment |
@rajadileepkolli thanks for the answer. My question was what the behaviour before 1.7. Maybe we could make that more transparent for our users. Would you create a temporary directory by default? Or disable persistence? |
@htynkn is your PR as well taking care of the ElasticsearchHealthSensor issue, which is caused by the ClusterHealthStatus package move? Can't spot anything like this in your PR, but I simply might miss it. If you have the elasticsearch healthsensor active and you try to visit /health you'll get this:
Looks like the compiler is creating a compile time dependency on ES <2.2 Just to complete it, you can get health system running, by (temporarily) deactivating the ES healthsensor |
@philnate thanks for your time to review pull request. Yes, you are right, sorry I didn't notice that issue. Looks like this pull request needs more work to check and fix, I would like to close this pull request first. If I get some time to fix issue and add default value for path.home, I can reopen this or create a new pull request. |
Can we leave it open? It might still be a good starting point. |
@htynkn I was about to review this PR this week still. One thing would be to remove the |
@snicoll Thanks. I have updated PR. with a properties "path.home", |
OK, I can take it from there I think. Thanks! |
* pr/5511: Polish contribution Upgrade elasticsearch to 2.2.0 Polish contribution Deprecate Undertow container's constructors that have a port parameter Remove unused unsatisfiedDependency.getInjectionPoint() call Polish contribution Allow Tomcat's minimum threads to be configured via the environment
ElasticSearch was using the current working directory as the default for the embedded node so I've kept that which means that all the other properties are now inferred from that. I've updated the doc and I think there are room for improvements for our elasticsearch support. |
Three major changes:
ClusterHealthStatus
ImmutableSettings
was removedpath.home
Fix #5443