Skip to content

upgrade elasticsearch to 2.2.0 #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

upgrade elasticsearch to 2.2.0 #5511

wants to merge 1 commit into from

Conversation

htynkn
Copy link
Contributor

@htynkn htynkn commented Mar 28, 2016

Three major changes:

  • package name change for ClusterHealthStatus
  • ImmutableSettings was removed
  • necessary param path.home

Fix #5443

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 28, 2016
@philwebb philwebb removed the status: waiting-for-triage An issue we've not yet triaged label Mar 28, 2016
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 28, 2016
@philwebb philwebb added this to the 1.4.0.M2 milestone Mar 28, 2016
@philwebb
Copy link
Member

@htynkn I know I've asked before, but can you confirm that you've signed the CLA.

@htynkn
Copy link
Contributor Author

htynkn commented Mar 29, 2016

@philwebb Yes, my confirmation number is 128120150629030655.

@snicoll
Copy link
Member

snicoll commented Mar 29, 2016

I wonder if we couldn't provide a default temp directory location for this new property rather than requiring the user to provide it. I am not sure what was happening before 2.2 (no persistence maybe?)

@rajadileepkolli
Copy link
Contributor

@snicoll it started from elasticsearch 2.0 as mandatory field so we are asking user to specify there they want elasticsearch to start in local environment

@snicoll
Copy link
Member

snicoll commented Mar 29, 2016

@rajadileepkolli thanks for the answer. My question was what the behaviour before 1.7. Maybe we could make that more transparent for our users. Would you create a temporary directory by default? Or disable persistence?

@snicoll snicoll self-assigned this Mar 29, 2016
@philwebb philwebb added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 29, 2016
@philnate
Copy link

@htynkn is your PR as well taking care of the ElasticsearchHealthSensor issue, which is caused by the ClusterHealthStatus package move? Can't spot anything like this in your PR, but I simply might miss it. If you have the elasticsearch healthsensor active and you try to visit /health you'll get this:

{
timestamp: 1459264185328,
status: 500,
error: "Internal Server Error",
exception: "java.lang.NoClassDefFoundError",
message: "org/elasticsearch/action/admin/cluster/health/ClusterHealthStatus",
path: "/mgmt/health"
}

Looks like the compiler is creating a compile time dependency on ES <2.2
Originating here: org/springframework/boot/actuate/health/ElasticsearchHealthIndicator.java:54

Just to complete it, you can get health system running, by (temporarily) deactivating the ES healthsensor management.health.elasticsearch.enabled=false

@htynkn
Copy link
Contributor Author

htynkn commented Mar 30, 2016

@philnate thanks for your time to review pull request. Yes, you are right, sorry I didn't notice that issue. Looks like this pull request needs more work to check and fix, I would like to close this pull request first. If I get some time to fix issue and add default value for path.home, I can reopen this or create a new pull request.

@htynkn htynkn closed this Mar 30, 2016
@philwebb
Copy link
Member

Can we leave it open? It might still be a good starting point.

@philwebb philwebb reopened this Mar 30, 2016
@snicoll
Copy link
Member

snicoll commented Mar 30, 2016

@htynkn I was about to review this PR this week still. One thing would be to remove the data and logs properties since I guess the new home one should be enough. If you intend to rework this PR, please push force on your exist branch to update this PR (let's keep the history in a single place). Let me know if you have time to work on this in the coming days. Thanks!

@htynkn
Copy link
Contributor Author

htynkn commented Mar 30, 2016

@snicoll Thanks. I have updated PR. with a properties "path.home", logs and data are not mandatory, so I remove them.
About the issue philnate metioned, I only find ClusterHealthStatus in test and the package name change is already included in this PR. I'm not sure after upgrade elasticsearch to 2.2.0, it will works well or not.

@snicoll
Copy link
Member

snicoll commented Mar 30, 2016

OK, I can take it from there I think. Thanks!

@snicoll snicoll removed the status: waiting-for-feedback We need additional information before we can continue label Mar 30, 2016
@snicoll snicoll closed this in 05ef081 Apr 5, 2016
snicoll added a commit that referenced this pull request Apr 5, 2016
* pr/5511:
  Polish contribution
  Upgrade elasticsearch to 2.2.0
  Polish contribution
  Deprecate Undertow container's constructors that have a port parameter
  Remove unused unsatisfiedDependency.getInjectionPoint() call
  Polish contribution
  Allow Tomcat's minimum threads to be configured via the environment
@snicoll snicoll added the type: enhancement A general enhancement label Apr 5, 2016
@snicoll
Copy link
Member

snicoll commented Apr 5, 2016

ElasticSearch was using the current working directory as the default for the embedded node so I've kept that which means that all the other properties are now inferred from that. I've updated the doc and I think there are room for improvements for our elasticsearch support.

@htynkn htynkn deleted the upgrade-elastic branch April 5, 2016 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants