Make use of spring-boot.version property in Spring Boot dependencies. #4873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using the property in Spring Boot dependencies' pom.xml, even projects that use the Spring Boot starter parent pom transitively can tweak the version of the dependencies independently from the parent pom. That might sound counterintuitive at first but image a project setup with a company wide parent pom that uses Boot's as parent itself but only gets released ocassionally (i.e. maybe per Boot generation 1.2, 1.3) etc. If that's in place, the leaf projects cannot upgrade to a newer Spring Boot version at all due to the way handles imports in <dependencyManagement /> sections [0]. That change allows users to st the spring-boot.version property and thus let Maven import the spring-boot-dependencies in the potentially newer version so that the dependency upgrades can be pulled in even if the reference to the parent isn't updated. [0] https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html
spring-projects-issues
added
the
status: waiting-for-triage
dsyer
added
type: enhancement
|
We've discussed and rejected this in the past. See #3992, for example. |
wilkinsona
added
status: duplicate
|
I commented on the other ticket, as I think this should really be reconsidered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the property in Spring Boot dependencies' pom.xml, even projects
that use the Spring Boot starter parent pom transitively can tweak the
version of the dependencies independently from the parent pom.
That might sound counterintuitive at first but image a project setup with
a company wide parent pom that uses Boot's as parent itself but only gets
released ocassionally (i.e. maybe per Boot generation 1.2, 1.3) etc. If
that's in place, the leaf projects cannot upgrade to a newer Spring Boot
version at all due to the way handles imports in
sections [0].
That change allows users to st the spring-boot.version property and thus
let Maven import the spring-boot-dependencies in the potentially newer
version so that the dependency upgrades can be pulled in even if the
reference to the parent isn't updated.
[0] https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html