Skip to content

Delegate getExecutionContextSerializer() to DefaultBatchConfiguration if not provided #39911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Mar 12, 2024

Like other delegations in SpringBootBatchConfiguration, it would be better to delegate getExecutionContextSerializer() to DefaultBatchConfiguration if a custom one is not provided rather than create one based on the current implementation of DefaultBatchConfiguration.getExecutionContextSerializer().

See gh-38328

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 12, 2024
@scottfrederick scottfrederick added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 12, 2024
@scottfrederick scottfrederick added this to the 3.3.0-M3 milestone Mar 12, 2024
scottfrederick pushed a commit that referenced this pull request Mar 12, 2024
@scottfrederick
Copy link
Contributor

Good catch @izeye, thanks!

@izeye izeye deleted the gh-gh-38328 branch March 12, 2024 23:19
@benelog
Copy link
Contributor

benelog commented Jun 24, 2024

With a similar intention, I revised it at https://github.com/spring-projects/spring-boot/pull/38631/files

this.serializer = executionContextSerializer.getIfAvailable(super::getExecutionContextSerializer);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants