Skip to content

Polish "Set Reactor Netty's shutdownQuietPeriod to 0 when using devtools" #34140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Polish "Set Reactor Netty's shutdownQuietPeriod to 0 when using devtools" #34140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...java/org/springframework/boot/autoconfigure/reactor/netty/ReactorNettyConfigurations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ private ReactorNettyConfigurations() {
}

@Configuration(proxyBeanMethods = false)
@EnableConfigurationProperties(ReactorNettyConfigurationProperties.class)
@EnableConfigurationProperties(ReactorNettyProperties.class)
public static class ReactorResourceFactoryConfiguration {

@Bean
@ConditionalOnMissingBean
ReactorResourceFactory reactorResourceFactory(ReactorNettyConfigurationProperties configurationProperties) {
ReactorResourceFactory reactorResourceFactory(ReactorNettyProperties configurationProperties) {
ReactorResourceFactory reactorResourceFactory = new ReactorResourceFactory();
if (configurationProperties.getShutdownQuietPeriod() != null) {
reactorResourceFactory.setShutdownQuietPeriod(configurationProperties.getShutdownQuietPeriod());
Expand Down
6 changes: 3 additions & 3 deletions .../ReactorNettyConfigurationProperties.java → ...reactor/netty/ReactorNettyProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@
import org.springframework.boot.context.properties.ConfigurationProperties;

/**
* Configuration properties for Reactor Netty configuration.
* Configuration properties for Reactor Netty.
*
* @author Moritz Halbritter
* @since 2.7.9
*/
@ConfigurationProperties(prefix = "spring.reactor.netty")
public class ReactorNettyConfigurationProperties {
public class ReactorNettyProperties {

/**
* Configure the amount of time to wait before shutting down resources.
* Amount of time to wait before shutting down resources.
*/
private Duration shutdownQuietPeriod;

Expand Down
2 changes: 1 addition & 1 deletion ...ain/resources/org/springframework/boot/devtools/env/devtools-property-defaults.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ spring.groovy.template.cache=false
spring.h2.console.enabled=true
spring.mustache.servlet.cache=false
spring.mvc.log-resolved-exception=true
spring.reactor.netty.shutdown-quiet-period=0s
spring.template.provider.cache=false
spring.thymeleaf.cache=false
spring.web.resources.cache.period=0
spring.web.resources.chain.cache=false
spring.reactor.netty.shutdown-quiet-period=0s