Skip to content

@FlywayDataSource does not work in an application that has multiple datasources #20617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public Flyway flyway(FlywayProperties properties, DataSourceProperties dataSourc
ObjectProvider<JavaMigration> javaMigrations, ObjectProvider<Callback> callbacks) {
FluentConfiguration configuration = new FluentConfiguration(resourceLoader.getClassLoader());
DataSource dataSourceToMigrate = configureDataSource(configuration, properties, dataSourceProperties,
flywayDataSource.getIfAvailable(), dataSource.getIfAvailable());
flywayDataSource.getIfAvailable(), dataSource.getIfUnique());
checkLocationExists(dataSourceToMigrate, properties, resourceLoader);
configureProperties(configuration, properties);
List<Callback> orderedCallbacks = callbacks.orderedStream().collect(Collectors.toList());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
* @author Stephane Nicoll
* @author Dominic Gunn
* @author András Deák
* @author Takaaki Shimbo
*/
@ExtendWith(OutputCaptureExtension.class)
class FlywayAutoConfigurationTests {
Expand Down Expand Up @@ -162,6 +163,15 @@ void flywayDataSourceWithoutDataSourceAutoConfiguration() {
});
}

@Test
void flywayMultipleDataSources() {
this.contextRunner.withUserConfiguration(FlywayMultipleDataSourcesConfiguration.class).run((context) -> {
assertThat(context).hasSingleBean(Flyway.class);
assertThat(context.getBean(Flyway.class).getConfiguration().getDataSource())
.isEqualTo(context.getBean("flywayDataSource"));
});
}

@Test
void schemaManagementProviderDetectsDataSource() {
this.contextRunner
Expand Down Expand Up @@ -509,6 +519,27 @@ DataSource flywayDataSource() {

}

@Configuration(proxyBeanMethods = false)
static class FlywayMultipleDataSourcesConfiguration {

@Bean
DataSource mainDataSource() {
return DataSourceBuilder.create().url("jdbc:hsqldb:mem:main").username("sa").build();
}

@Bean
DataSource secondlyDataSource() {
return DataSourceBuilder.create().url("jdbc:hsqldb:mem:secondly").username("sa").build();
}

@FlywayDataSource
@Bean
DataSource flywayDataSource(DataSource mainDataSource) {
return mainDataSource;
}

}

@Configuration(proxyBeanMethods = false)
static class FlywayJavaMigrationsConfiguration {

Expand Down