Liquibase actuator endpoint does not give correct information when multiple databases are used in one project #19171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Nov 28, 2019
wilkinsona
added
the
status: waiting-for-feedback
|
Sure, I test in local, and see if there is an easy way to migrate to test. |
spring-projects-issues
added
status: feedback-provided
|
For the original LiquibaseEndpoint code, this test returns: For the fixed code, it can pass the test correctly. |
wilkinsona
added
type: bug
wilkinsona
changed the title
wilkinsona
approved these changes
Nov 29, 2019
wilkinsona
pushed a commit
that referenced
this pull request
Nov 29, 2019
Previously, the endpoint used the same change log history service for for each SpringLiquibase bean that it processed. This resulted in pollution of the reported changes as the history of each bean was not isolated. This commit updates the endpoint to use a new history service for each SpringLiquibase bean that is processed. See gh-19171
wilkinsona
added a commit
that referenced
this pull request
Nov 29, 2019
|
Thanks again, @polarbear567. The proposed changes have been merged into 2.1.x and forwards to 2.2.x and master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.