-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Add JUnit 4 and the Vintage Engine sample #17100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
64ca56d
to
d24446f
Compare
@philwebb @mbhave @wilkinsona JUnit 5 checkstyle rules introduced in #17093 are applied to |
May be add a suppression for |
@ielatif Yes, I think that's the right approach. |
@wilkinsona raised this PR to fix |
This commit adds a sample to verify the use of JUnit 4 and the Vintage Engine. Closes spring-projects#17070.
This commit adds a sample to verify the use of JUnit 4 and the Vintage Engine. See gh-17100
@ielatif thanks for the PR. I've polished in two main areas:
|
Totaly agree 👍
I was thinking of the sample as a sample application (application running an embedded web server) and not as a smoke test like @philwebb mentioned in a newly raised feature. |
This commit adds a sample to verify the use of JUnit 4 and the Vintage Engine.
Closes #17070.