Skip to content

Handle missing exceptions in WebMvcMetricsFilter #16014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Handle missing exceptions in WebMvcMetricsFilter #16014

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Feb 22, 2019

This PR changes to handle missing exceptions in WebMvcMetricsFilter.filterAndRecordMetrics(). This was originally reported in micrometer-metrics/micrometer#1190.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 22, 2019
@izeye izeye mentioned this pull request Feb 22, 2019
Closed
@bclozel bclozel self-assigned this Mar 12, 2019
@kbalsam
Copy link

kbalsam commented Mar 12, 2019

@izeye I am having this issue as well I believe (metrics with status:200 and status:400 have the corresponding tags, but I can't see status:500 tags). Also, I think your build failed.
[INFO] Spring Boot Data REST Sample ....................... FAILURE [ 15.998 s]

@kbalsam
Copy link

kbalsam commented Mar 12, 2019

@izeye I am having this issue as well I believe (metrics with status:200 and status:400 have the corresponding tags, but I can't see status:500 tags). Also, I think your build failed.
[INFO] Spring Boot Data REST Sample ....................... FAILURE [ 15.998 s]

Correction, I was being foolish. I had created a WebMvcTagsProvider, but had not carried over WebMvcTags.status(response).

@bclozel bclozel added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 13, 2019
@bclozel bclozel added this to the 2.0.9 milestone Mar 13, 2019
@bclozel bclozel changed the title Handle missing exceptions in WebMvcMetricsFilter.filterAndRecordMetrics() Handle missing exceptions in WebMvcMetricsFilter Mar 13, 2019
bclozel pushed a commit that referenced this pull request Mar 13, 2019
@izeye @bclozel
Handle missing exceptions in WebMvcMetricsFilter
a6ccdbe 
Prior to this commit, exceptions nested in
`NestedServletExceptions` would not be recorded by the
`WebMvcMetricsFilter`. This commit ensures that exceptions
happening downstream (e.g. happening while writing the response
body itself) are properly recorded.

See micrometer-metrics/micrometer#1190
See gh-16014
@bclozel bclozel closed this in 6138041 Mar 13, 2019
@izeye izeye deleted the micrometer-gh-1190 branch March 13, 2019 11:58
izeye added a commit to izeye/micrometer that referenced this pull request Mar 13, 2019
@izeye
Handle missing exceptions in WebMvcMetricsFilter
b8f91c5 
Closes micrometer-metricsgh-1190
See spring-projects/spring-boot#16014
@izeye izeye mentioned this pull request Mar 13, 2019
Merged
@izeye
Copy link
Contributor Author

izeye commented Mar 13, 2019

@bclozel Thanks for merging this and adding tests 👍

I created micrometer-metrics/micrometer#1284 to backport the changes into the Spring Boot legacy module in Micrometer.

shakuzen pushed a commit to micrometer-metrics/micrometer that referenced this pull request Mar 14, 2019
@izeye @shakuzen
Handle missing exceptions in WebMvcMetricsFilter (#1284)
33da69f 
Closes gh-1190
See spring-projects/spring-boot#16014
@haykart haykart mentioned this pull request Apr 1, 2019
Closed
@mbhave mbhave mentioned this pull request Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bclozel bclozel

Labels
type: bug A general bug
Projects
None yet
Milestone
2.0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@izeye @kbalsam @bclozel @spring-projects-issues