Warn about dropped Quartz tables #15295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default init scripts drop all tables, as in [the Postgres script](https://github.com/quartz-scheduler/quartz/blob/master/quartz-core/src/main/resources/org/quartz/impl/jdbcjobstore/tables_postgres.sql). Since the only options are `always` or `never`, they are useless for most production settings. More importantly, they deserve a warning, as they should not be used carelessly.
spring-projects-issues
added
the
status: waiting-for-triage
|
@Grannath Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Grannath Thank you for signing the Contributor License Agreement! |
wilkinsona
added
type: documentation
wilkinsona
added a commit
that referenced
this pull request
Nov 27, 2018
* gh-15295: Warn about Quartz dropping tables on restart
|
@Grannath Thank you very much for making your first contribution to Spring Boot. I've merged the proposed changes into 2.0.x and forwards into master. |
|
@wilkinsona Wow, that was easy. 😅 If this is how PRs get handled in Spring projects, count me in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Quartz init scripts drop all tables, as in the Postgres script. Since the only options are
alwaysornever, they are useless for most production settings.We discovered this the hard way today. I do not understand who in the Quartz project decides on defaults like this. But at the very least the Spring Boot documentation deserves a warning, since it mentions this setting.