Scoped targets such as those created by @RefreshScope are not skipped when discovering endpoint beans #15182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rahul404 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@rahul404 Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: bug
wilkinsona
changed the title
philwebb
changed the title
philwebb
changed the title
philwebb
added a commit
that referenced
this pull request
Nov 15, 2018
philwebb
added a commit
that referenced
this pull request
Nov 15, 2018
* pr/15182: Polish "Skip scoped targets when determining endpoints" Skip scoped targets when determining endpoints
|
@rahul404 Thanks very much for your first contribution to Spring Boot. This has now been merged into 2.0.x and master. I've made one small polish commit that saves an unnecessary call to Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #15063 .
The code make changes to
spring-boot/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/annotation/EndpointDiscoverer.java
to skip any beans whose name is prefixed with "scopedTarget."