Skip to content

Use Errors.hasErrors() in DefaultErrorAttributes #14912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use Errors.hasErrors() in DefaultErrorAttributes #14912

wants to merge 1 commit into from

Conversation

dreis2211
Copy link
Contributor

Hi,

this PR replaces occurences of result.getErrorCount() > 0 with result.hasErrors() where applicable.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 20, 2018
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 21, 2018
@philwebb philwebb added this to the 2.1.x milestone Oct 21, 2018
@mbhave mbhave modified the milestones: 2.1.x, 2.0.7 Oct 23, 2018
mbhave added a commit that referenced this pull request Oct 23, 2018
@mbhave
Merge pull request #14912 from dreis2211
44e9601 
* gh-14912:
  Use Errors.hasErrors() in DefaultErrorAttributes
@mbhave mbhave closed this in 3fea487 Oct 23, 2018
@mbhave
Copy link
Contributor

mbhave commented Oct 23, 2018

Thanks again @dreis2211. This is now on master.

@philwebb philwebb added type: task A general task and removed type: enhancement A general enhancement labels Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
2.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@dreis2211 @mbhave @philwebb @spring-projects-issues