Set hostname property for JMX in spring-boot-maven-plugin #14836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
the
for: team-attention
snicoll
approved these changes
Oct 17, 2018
snicoll
added
type: bug
snicoll
added a commit
that referenced
this pull request
Oct 17, 2018
* pr/14836: Force JMX hostname to 127.0.0.1
|
@goughy000 thank you for making your first contribution to Spring Boot. This is now merged in |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue seen on some machines where the local hosts file has none-standard entries. In this case, the build hangs with the following message written to debug until eventually giving up and failing
Spring application is not ready yet, waiting XXms (attempt Y)In
SpringApplicationAdminClient, the connection URLservice:jmx:rmi:///jndi/rmi://127.0.0.1is used, however it's possible that the forked JVM has bound to a different address.Adding this extra system property helps to ensure that the JVM will bind rmi to the correct interface.
We have previously been adding this as a custom jvmarg in the plugin configuration, but I think it makes sense for it to be part of the plugin