Skip to content

Anonymous exception leads to empty exception tags in WebMvc/WebFlux metrics #13817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jkschneider
Copy link
Contributor

Empty tag values are rejected by some monitoring systems.

See micrometer-metrics/micrometer#680.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 18, 2018
@snicoll snicoll self-assigned this Jul 19, 2018
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 19, 2018
@snicoll snicoll added this to the 2.0.4 milestone Jul 19, 2018
snicoll added a commit that referenced this pull request Jul 19, 2018
* pr/13817:
  Polish "Make sure exception tag values are not empty in web metrics"
  Make sure exception tag values are not empty in web metrics
@snicoll
Copy link
Member

snicoll commented Jul 19, 2018

Closed by ee37dc1 (with the wrong issue id, sorry)

@snicoll snicoll closed this Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants