Base unit of metric values is unspecified when using the metrics endpoint #13813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Jul 19, 2018
There was a problem hiding this comment.
Thanks for the PR. Can you please update the documentation to describe the new fields?
snicoll
added
the
status: waiting-for-feedback
|
@wilkinsona I did the requested changes. |
wilkinsona
changed the title
wilkinsona
added
type: bug
snicoll
approved these changes
Jul 23, 2018
snicoll
pushed a commit
that referenced
this pull request
Jul 24, 2018
snicoll
added a commit
that referenced
this pull request
Jul 24, 2018
* pr/13813: Polish "Add metric description and base unit to metrics endpoint" Add metric description and base unit to metrics endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13791