Skip to content

Improve description of Endpoint exclude #13619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

72MiguelGomes
Copy link
Contributor

After reading the code notice that the * was also valid for exclusion and that was not documented as in included fields.

Example:

ExposeExcludePropertyEndpointFilter.class

private boolean isExposed(ExposableEndpoint<?> endpoint) {
	if (this.include.isEmpty()) {
		return this.exposeDefaults.contains("*")
				|| contains(this.exposeDefaults, endpoint);
	}
	return this.include.contains("*") || contains(this.include, endpoint);
}

private boolean isExcluded(ExposableEndpoint<?> endpoint) {
	if (this.exclude.isEmpty()) {
		return false;
	}
	return this.exclude.contains("*") || contains(this.exclude, endpoint);
}

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 30, 2018
@philwebb philwebb added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 30, 2018
@philwebb philwebb added this to the 2.0.x milestone Jun 30, 2018
@philwebb
Copy link
Member

philwebb commented Jun 30, 2018

Good spot. Thanks for the pull-request!

@72MiguelGomes 72MiguelGomes force-pushed the small-documentation-improve branch from 7e6b560 to 1ba7737 Compare June 30, 2018 16:02
@72MiguelGomes 72MiguelGomes force-pushed the small-documentation-improve branch from 1ba7737 to dc48092 Compare July 1, 2018 00:19
@snicoll snicoll self-assigned this Jul 9, 2018
@snicoll snicoll changed the title Documentation Improve Improve description of Endpoint exclude Jul 9, 2018
@snicoll snicoll added the for: merge-with-amendments Needs some changes when we merge label Jul 9, 2018
snicoll pushed a commit that referenced this pull request Jul 9, 2018
snicoll added a commit that referenced this pull request Jul 9, 2018
* pr/13619:
  Polish "Improve description of Endpoint exclude"
  Improve description of Endpoint exclude
@snicoll snicoll modified the milestones: 2.0.x, 2.0.4 Jul 9, 2018
@snicoll snicoll closed this in 44b9aa1 Jul 9, 2018
@snicoll
Copy link
Member

snicoll commented Jul 9, 2018

@72MiguelGomes thank you for your first contribution to Spring Boot. This is now merged in 2.0.x and master. I've polished your contribution in 44b9aa1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: merge-with-amendments Needs some changes when we merge type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants