Skip to content

TraceableHttpServletRequest encodes query strings incorrectly #13545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Jun 21, 2018

This PR fixes query string encoding in TraceableHttpServletRequest as encoding "=" doesn't seem to be right.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 21, 2018
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 26, 2018
@philwebb philwebb added this to the 2.0.x milestone Jun 26, 2018
@snicoll snicoll modified the milestones: 2.0.x, 2.0.4 Jul 10, 2018
snicoll added a commit that referenced this pull request Jul 10, 2018
* pr/13545:
  Fix query string encoding in TraceableHttpServletRequest
@snicoll
Copy link
Member

snicoll commented Jul 10, 2018

Good catch again @izeye, thanks!

@snicoll snicoll closed this in 46e6aa5 Jul 10, 2018
@izeye izeye deleted the fix-traceable-query-string branch July 10, 2018 14:02
@wilkinsona wilkinsona changed the title Fix query string encoding in TraceableHttpServletRequest TraceableHttpServletRequest encodes query strings incorrectly Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants