Use instance equality for Class #11534
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
@izeye I am not sure that this change was a call to harmonization across the codebase (though I guess that shouldn't hurt but, again, we should write that down somewhere then). Flagging for team attention. |
snicoll
added
the
for: team-attention
|
The change in 2efa21c was a specific suggestion from JitWatch. It can't hurt to align the others, although they're probably not on such hot code-paths so it's certainly less critical. |
philwebb
added
priority: normal
type: enhancement
snicoll
removed
the
for: team-attention
snicoll
added a commit
that referenced
this pull request
Jan 9, 2018
* pr/11534: Use instance equality for Class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to use instance equality for
Classto be consistent with the change via 2efa21c.