Skip to content

Add Spring Session WebFlux sample #11055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Nov 16, 2017

This PR adds Spring Session WebFlux sample app to demonstrate the auto-configuration capabilities for reactive Spring Session.

The sample uses MongoDB profile by default and uses an embedded MongoDB to avoid dependencies on external services, similarly like spring-boot-sample-session uses JDBC profile by default.

I've also included an integration test however this has uncovered issues with Spring Session MongoDB auto-configuration that require fixes on multiple levels, see #11054 and spring-projects/spring-session-data-mongodb#19 - both of these are required to make this integration test to work.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 16, 2017
@philwebb philwebb added priority: normal type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 16, 2017
@philwebb philwebb added this to the 2.0.0.M7 milestone Nov 16, 2017
@philwebb philwebb self-assigned this Nov 16, 2017
@vpavic vpavic force-pushed the session-webflux-sample branch from 25f741e to 25bd034 Compare November 17, 2017 13:26
@vpavic
Copy link
Contributor Author

vpavic commented Nov 17, 2017

In order for this to make 2.0.0.M7, Spring Session Data MongoDB would need to release 2.0.0.RC2 with spring-projects/spring-session-data-mongodb#19 - ping @gregturn.

@vpavic vpavic force-pushed the session-webflux-sample branch from 6579dea to 9d0f024 Compare November 20, 2017 12:38
@vpavic
Copy link
Contributor Author

vpavic commented Nov 20, 2017

With spring-session-data-mongodb bumped to 2.0.0.BUILD-SNAPSHOT in e4e635f this PR now builds successfully.

I also had to provide some security config due to recent change in Spring Security (spring-projects/spring-security#4825)

@philwebb philwebb removed the status: blocked An issue that's blocked on an external project change label Nov 20, 2017
philwebb pushed a commit that referenced this pull request Nov 23, 2017
@philwebb philwebb closed this in 4412285 Nov 23, 2017
philwebb added a commit that referenced this pull request Nov 23, 2017
* pr/11055:
  Polish Spring Session WebFlux sample
  Add Spring Session WebFlux sample
@vpavic vpavic deleted the session-webflux-sample branch November 23, 2017 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants