-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Add web test client restdocs autoconfiguration #10969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
56ad74f
Add web test client restdocs autoconfiguration
zaynetro 0af9dc7
Remove comment
zaynetro dfd63b2
Fix checkstyle violations
zaynetro 9e449aa
Add restdocs webtestclient dependency
zaynetro 2786521
Use correct document import
zaynetro 4f1c03d
Use reactive type
zaynetro 5b0c5aa
Add static webclienttest document to checkstyle
zaynetro 9cccae5
Customize web test client
zaynetro 973b984
Format files
zaynetro bc7d330
Remove unused imports
zaynetro 2963eb7
Add default web test client builder customizer
zaynetro 3b62b92
Reorder imports
zaynetro 24e3da7
Use application context from field
zaynetro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 90 additions & 0 deletions
90
...ingframework/boot/test/autoconfigure/restdocs/RestDocsWebTestClientBuilderCustomizer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
/* | ||
* Copyright 2012-2017 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.test.autoconfigure.restdocs; | ||
|
||
import org.springframework.beans.factory.InitializingBean; | ||
import org.springframework.boot.test.autoconfigure.web.reactive.WebTestClientBuilderCustomizer; | ||
import org.springframework.restdocs.webtestclient.WebTestClientRestDocumentationConfigurer; | ||
import org.springframework.test.web.reactive.server.WebTestClient; | ||
import org.springframework.util.StringUtils; | ||
|
||
/** | ||
* A customizer that configures Spring REST Docs with WebTestClient. | ||
* | ||
* @author Eddú Meléndez | ||
* @author Roman Zaynetdinov | ||
*/ | ||
class RestDocsWebTestClientBuilderCustomizer implements InitializingBean, WebTestClientBuilderCustomizer { | ||
|
||
private final WebTestClientRestDocumentationConfigurer delegate; | ||
|
||
private String uriScheme; | ||
|
||
private String uriHost; | ||
|
||
private Integer uriPort; | ||
|
||
RestDocsWebTestClientBuilderCustomizer(WebTestClientRestDocumentationConfigurer delegate) { | ||
this.delegate = delegate; | ||
} | ||
|
||
public String getUriScheme() { | ||
return this.uriScheme; | ||
} | ||
|
||
public void setUriScheme(String uriScheme) { | ||
this.uriScheme = uriScheme; | ||
} | ||
|
||
public String getUriHost() { | ||
return this.uriHost; | ||
} | ||
|
||
public void setUriHost(String uriHost) { | ||
this.uriHost = uriHost; | ||
} | ||
|
||
public Integer getUriPort() { | ||
return this.uriPort; | ||
} | ||
|
||
public void setUriPort(Integer uriPort) { | ||
this.uriPort = uriPort; | ||
} | ||
|
||
@Override | ||
public void afterPropertiesSet() throws Exception { | ||
} | ||
|
||
@Override | ||
public void customize(WebTestClient.Builder builder) { | ||
if (StringUtils.hasText(this.uriScheme) && StringUtils.hasText(this.uriHost)) { | ||
String baseUrl = this.uriScheme + "://" + this.uriHost; | ||
|
||
if (this.uriPort == 80 && this.uriScheme.equals("http")) { | ||
// Don't add default port | ||
} else if (this.uriPort == 443 && this.uriScheme.equals("https")) { | ||
// Don't add default port | ||
} else if (this.uriPort != null) { | ||
baseUrl += ":" + this.uriPort; | ||
} | ||
|
||
builder.baseUrl(baseUrl); | ||
} | ||
builder.filter(this.delegate); | ||
} | ||
} |
42 changes: 42 additions & 0 deletions
42
...mework/boot/test/autoconfigure/restdocs/RestDocsWebTestClientConfigurationCustomizer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Copyright 2012-2017 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.test.autoconfigure.restdocs; | ||
|
||
import org.springframework.restdocs.webtestclient.WebTestClientRestDocumentationConfigurer; | ||
|
||
/** | ||
* A customizer for {@link WebTestClientRestDocumentationConfigurer}. If a | ||
* {@code RestDocsWebTestClientConfigurationCustomizer} bean is found in the application context | ||
* it will be {@link #customize called} to customize the | ||
* {@code WebTestClientRestDocumentationConfigurer} before it is applied. Intended for use only | ||
* when the attributes on {@link AutoConfigureRestDocs} do not provide sufficient | ||
* customization. | ||
* | ||
* @author Andy Wilkinson | ||
* @author Roman Zaynetdinov | ||
* @since 2.0.0 | ||
*/ | ||
@FunctionalInterface | ||
public interface RestDocsWebTestClientConfigurationCustomizer { | ||
|
||
/** | ||
* Customize the given {@code configurer}. | ||
* @param configurer the configurer | ||
*/ | ||
void customize(WebTestClientRestDocumentationConfigurer configurer); | ||
|
||
} |
82 changes: 82 additions & 0 deletions
82
...mework/boot/test/autoconfigure/web/reactive/SpringBootWebTestClientBuilderCustomizer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/* | ||
* Copyright 2012-2017 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.test.autoconfigure.web.reactive; | ||
|
||
import java.time.Duration; | ||
import java.util.Collection; | ||
import java.util.function.Consumer; | ||
|
||
import org.springframework.boot.context.properties.bind.Binder; | ||
import org.springframework.boot.web.codec.CodecCustomizer; | ||
import org.springframework.context.ApplicationContext; | ||
import org.springframework.http.codec.ClientCodecConfigurer; | ||
import org.springframework.test.web.reactive.server.WebTestClient; | ||
import org.springframework.util.Assert; | ||
import org.springframework.util.CollectionUtils; | ||
import org.springframework.web.reactive.function.client.ExchangeStrategies; | ||
|
||
/** | ||
* {@link WebTestClientBuilderCustomizer} for a typical Spring Boot application. Usually applied | ||
* automatically via {@link AutoConfigureWebTestClient @AutoConfigureWebTestClient}, but may also be | ||
* used directly. | ||
* | ||
* @author Phillip Webb | ||
* @author Andy Wilkinson | ||
* @author Roman Zaynetdinov | ||
* @since 2.0.0 | ||
*/ | ||
public class SpringBootWebTestClientBuilderCustomizer implements WebTestClientBuilderCustomizer { | ||
|
||
private final ApplicationContext context; | ||
|
||
/** | ||
* Create a new {@link SpringBootWebTestClientBuilderCustomizer} instance. | ||
* @param context the source application context | ||
*/ | ||
public SpringBootWebTestClientBuilderCustomizer(ApplicationContext context) { | ||
Assert.notNull(context, "Context must not be null"); | ||
this.context = context; | ||
} | ||
|
||
@Override | ||
public void customize(WebTestClient.Builder builder) { | ||
customizeWebTestClient(builder); | ||
customizeWebTestClientCodecs(builder); | ||
} | ||
|
||
private void customizeWebTestClient(WebTestClient.Builder builder) { | ||
Binder.get(this.context.getEnvironment()) | ||
.bind("spring.test.webtestclient.timeout", Duration.class) | ||
.ifBound(builder::responseTimeout); | ||
} | ||
|
||
private void customizeWebTestClientCodecs(WebTestClient.Builder builder) { | ||
Collection<CodecCustomizer> customizers = this.context | ||
.getBeansOfType(CodecCustomizer.class).values(); | ||
if (!CollectionUtils.isEmpty(customizers)) { | ||
builder.exchangeStrategies(ExchangeStrategies.builder() | ||
.codecs(this.applyCustomizers(customizers)).build()); | ||
} | ||
} | ||
|
||
private Consumer<ClientCodecConfigurer> applyCustomizers( | ||
Collection<CodecCustomizer> customizers) { | ||
return (codecs) -> customizers | ||
.forEach((customizer) -> customizer.customize(codecs)); | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
org.springframework.restdocs.webtestclient.WebTestClientRestDocumentation.*