Improve Elasticsearch ServiceConnection

[eddumelendez]

Currently, ElasticsearchContainerConnectionDetailsFactory only maps nodes and that works with Elasticsearch 7. However, Elasticsearch 8 has security enabled by default and additional configuration is required.

This is an example using Elasticsearch 7 and this one using Elasticsearch 8. As you can see, with Elasticsearch 8 the SSLContext is provided via a customizer so the connection through https is successful.

You can find a draft proposal here. I tried to do it via ssl bundles by copying the http_ca.crt from the container to the test resources directory but I couldn't set it up correctly.

[Divyansh1711]

I m beginner and i have no idea ...how to start contributing for project.. Anyone any guides for me??

[wilkinsona]

Thanks for your interest in contributing. I'm not sure if we have any at the moment, but please keep an eye out for unassigned issues labelled with ideal for contribution or, if you haven't contributed before, first-timers only.

[kevinwheeler]

I'll see if this ends up being over my head or not, but I'm starting to investigate this / work on it. Feedback is always welcome. I am only slightly familiar with Spring Boot, having used JHipster to make a simple app recently, and I haven't used Elasticsearch yet.

[kevinwheeler]

Something came up that I'm going to have to work on for at least a few days before I can get back to this unfortunately.

[kevinwheeler]

It's going to be a while before I can get back to this actually. Perhaps a week.

Edit: I'm looking into this issue again currently.

[kevinwheeler]

Hi all, can you all confirm to me what the goal here is exactly? Are we wanting to make it such that users can use Elasticsearch 8 Testcontainers without having to configure the SSL manually using a RestClientBuilderCustomizer? Probably while keeping SSL enabled?

@eddumelendez the bulk of your edits in your draft proposal were in the DataElasticsearchTestIntegrationTests.java file, so I wanted to clarify and ask. That file is for tests that are for internal use by the Spring team, right? Were you just tinkering around in there for dev purposes? I assume we would be wanting to modify other files instead to provide the functionality we are going for, right? By the way passing in "docker.elastic.co/elasticsearch/elasticsearch:8.7.1" (or better yet, modifying DockerImageNames.elasticsearch8()) to the ElasticsearchContainer constructor in that test file in your draft proposal makes the tests pass, but you're probably already way ahead of me. Currently it's using Elasticsearch 7.