Skip to content

Incorrect detection of Amazon Redshift #25128

Closed
@lbruun

Description

@lbruun

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general ideal-for-contribution issues. Thanks!

Problem

Detection of Amazon Redshift in org.springframework.boot.jdbc.DataBaseDriver is incorrect. The Redshift JDBC driver returns Redshift as the productName but we are using Amazon Redshift as the productName.

Solution

Update the DatabaseDriver enum with the right value for the productName for Redshift.

Update the tests to ensure that the right DatabaseDriver.fromProductName() works for Redshift.

Steps to Fix

  • Claim this issue with a comment below and ask any clarifying questions you need
  • Set up a repository locally following the Contributing Guidelines
  • Try to fix the issue following the steps above
  • Commit your changes and start a pull request.

Metadata

Metadata

Assignees

Labels

status: first-timers-onlyAn issue that can only be worked on by brand new contributorsstatus: supersededAn issue that has been superseded by anothertype: bugA general bug

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions