Checkstyle is not catching Mockito.when

[philwebb]

Called to Mockito.when should fail, but a few have somehow snuck in.

[philwebb]

E.g. HazelcastHealthIndicatorTests.

[mbhave]

@philwebb I couldn't find any usages of Mockito.when. HazelcastHealthIndicatorTests is using BDDMockito.when.

[philwebb]

Ahh, that explains it. There isn't a BDDMockito.when static method, it's picking it up because BDDMockito extends Mockito and there's a Mockito.when. Really we should bad static references like that.

Eclipse has a cleanup rule call "Change all access though subtype" which gets applied. If I did a cleanup on HazelcastHealthIndicatorTests it would change BDDMockito.when to Mockito.when and then we'd see checkstyle fail.