spring.resources.cache.period doesn't work

[OrangeDog]

Spring Boot 2.1.4.RELEASE

As far as I can tell, the property spring.resources.cache.period can't ever do anything.
ResourceProperties.Cache.Cachecontrol.toHttpCacheControl will always return an object, therefore this else branch is never taken.

A possible fix is to ensure toHttpCacheControl returns null if no properties are set.

[snicoll]

The cache period is configured as the MaxAge of the CacheControl. There is also a test that asserts it is set.

Rather than describing a technical solution, can you share a sample we can run that reproduces the problem you're experiencing?

[OrangeDog]

Sorry, this is with WebMVC, not WebFlux.
It's reproduced with spring-boot-starter-web, no config, a single static file, and the ...period property set to something valid.

[snicoll]

And what are we supposed to reproduce with this setup? MVC is also covered by a test that's passing at the moment. Can we please ignore the technical analysis and focus on the feature?

[OrangeDog]

I am focussing on the feature. Despite whatever tests might exist, it doesn't actually work.
Here's an explicit reproduction: https://gist.github.com/OrangeDog/8899a0b33561c3aa2100d9fe94a40f3f

$ curl -i http://localhost:8080/test.js
HTTP/1.1 200
Last-Modified: Mon, 08 Apr 2019 11:53:35 GMT
Accept-Ranges: bytes
Content-Type: application/javascript
Content-Length: 0
Date: Mon, 08 Apr 2019 12:15:09 GMT

[snicoll]

Thanks for the reproduction.