ExecutionContext.isDirty() is not very accurate [BATCH-1566]

[spring-projects-issues]

Dave Syer opened BATCH-1566 and commented

A context is only dirty if a new value is put or an old one is removed, but the implementation sets dirty on all puts.

---

Referenced from: commits 963142c

[spring-projects-issues]

Dave Syer commented

Fixed with check involving comparing the result of map.put/remove with the value passed in.

[spring-projects-issues]

Chris French commented

Should the fix check if the flag is already dirty as well before setting it to false in cases where the put is the same value as exists? If the isDirty flag is already true shouldn't it remain dirty/true? I just noticed this in the SimpleStepExecutionSplitter where the isDirty flag on restart is false. In our case the previous execution failed in the partition method so the partition method needs to be called again to set the contexts up. Seems like this dirty flag is the culprit.