Skip to content

ToolContext is now excluded from JSON Schema Generation #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

ThomasVitale
Copy link
Contributor

When generating the JSON Schema for a tool input from a method, ToolContext is now excluded since it's not something we want the model to provide. The framework takes care of passing a value for it when actually executing the tool call.

Fixes gh-2366

@ThomasVitale ThomasVitale marked this pull request as draft March 27, 2025 15:46
When generating the JSON Schema for a tool input from a method, ToolContext is now excluded since it's not something we want the model to provide. The framework takes care of passing a value for it when actually executing the tool call.

Fixes spring-projectsgh-2366

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@ThomasVitale ThomasVitale marked this pull request as ready for review March 27, 2025 16:29
@tzolov tzolov self-assigned this Mar 27, 2025
@tzolov tzolov added this to the 1.0.0-M7 milestone Mar 27, 2025
Copy link
Contributor

@tzolov tzolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzolov tzolov merged commit 8329402 into spring-projects:main Mar 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New JSON schema generation includes ToolContext, while old implementation skips it.
2 participants