Skip to content

PHP 7.1.2 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 24, 2022
Merged

PHP 7.1.2 #185

merged 4 commits into from
May 24, 2022

Conversation

mmelograno
Copy link
Contributor

PHP SDK

What did you accomplish?

  • Updated validations to comply with PHP8's stricter type validations.

How do we test the changes introduced in this PR?

Extra Notes

@sonarqube-pull-requests
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

mredolatti
mredolatti approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@mredolatti mredolatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@mmelograno mmelograno merged commit 566623d into master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Israphel Israphel Israphel approved these changes

@mredolatti mredolatti mredolatti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmelograno @Israphel @mredolatti