Skip to content

Impressions toggle #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2025
Merged

Impressions toggle #138

merged 4 commits into from
Jan 17, 2025

Conversation

EmilianoSanchez
Copy link
Contributor

JS Browser SDK

What did you accomplish?

How do we test the changes introduced in this PR?

Extra Notes

@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review January 17, 2025 21:32
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner January 17, 2025 21:32
@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)
Failed condition 12.3% 12.26% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@EmilianoSanchez EmilianoSanchez merged commit 883f021 into development Jan 17, 2025
7 of 8 checks passed
@EmilianoSanchez EmilianoSanchez deleted the impressions_toggle branch January 17, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanzmauro sanzmauro sanzmauro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilianoSanchez @sanzmauro