Fix numbered list rendering #5
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4.
Before
(Notice that only child numbering is correct)
After
The current way numbered lists are rendered resulted in every list item being wrapped in an
ol
. This is likely due to the weird way notion renders these number lists.A list isn't actually hierarchical as one might expect. There isn't a top level list block that contains sub block entries. Rather notion just infers that grouped numbered list items on the same level are related to the same group.
To achieve this I updated the logic of the
NotionRenderer
to have a reducer that goes over a block's child content and groups list items into what I've termed as aBlockGroup
. ABlockGroup
can specify it's own wrapper (like ul or ol) to group related items in.I'll comment more in line.