Add support for Figma Embed Link #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transitive-bullshit
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
LGTM.
I've already added support for a variety of embeds including figma in my fork, but for now I think we should merge this.
Here's a public notion page I created for testing different types of embeds: https://www.notion.so/saasifysh/Embeds-5d4e290ca4604d8fb809af806a6c1749
tobiaslins
requested changes
Aug 17, 2020
src/components/asset.tsx
Outdated
| > | ||
| <iframe | ||
| className="notion-image-inset" | ||
| src={value.properties.source[0][0]} |
There was a problem hiding this comment.
can we move this into (type === "embed" || type === "video") and add || type === "figma"
and then:
<iframe
className="notion-image-inset"
src={type === "figma" ? value.properties.source[0][0] : display_source}
/>we can also improve the if with
["embed","video","figma"].includes(type)
vinpac
commented
Aug 18, 2020
src/components/asset.tsx
Outdated
| > | ||
| <iframe | ||
| className="notion-image-inset" | ||
| src={value.properties.source[0][0]} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First, this lib rocks! 🚀
Second, I'm building my blog and realized some embed link were'nt supported yet. My plan was to send a PR for codepen, tweet and other assets, but only figma has
block.format.block_heightandwidthto calculate the aspect ratio.This PR adds support for Figma embed links.
Screenshot of it: