Skip to content

Added LoRa Thing Plus variant #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dandobs
Copy link

@dandobs dandobs commented Dec 9, 2020

Added target for LoRa thing plus in mbed to support Arduino core.
Submitting along with PR sparkfun/Arduino_Apollo3#305, adding the LoRa thing plus variant to Arduino core

@Wenn0101 Wenn0101 force-pushed the ambiq-apollo3-arduino branch from 14231bc to 1e8f3b9 Compare December 9, 2020 20:44
@oclyke
Copy link

oclyke commented Dec 17, 2020

Hi @danJTDC,
Thanks for making this PR. I can see that there are a lot of unrelated changes included. I would recommend reducing this PR to only the changes that were required to add the variant. This could involve several strategies including:

  • rebasing off the latest 'ambiq-apollo3-arduino' branch
  • starting fresh from the 'ambiq-apollo3-arduino' branch and applying only the necessary changes
  • or any number of other methods - lots of ways to skin a cat!

@Wenn0101 do you have any other comments on this?

Getting this PR pulled in is a prerequisite for Arduino Apollo3 PR #305

@dandobs
Copy link
Author

dandobs commented Dec 18, 2020

Hi @oclyke,
I updated my fork to the latest version and made only the changes required to add the variant.
This was closed automatically in the process, I submitted a new PR with those changes #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants