Security, registration, MQTT, FILE write and improvements #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Security APIs - MQTT APIs - File download - improved ERROR parsing - debug capability to see raw AT commands and responses
- Avoid nasty recursion in init just use a do - while loop. recursion is almost always a bad thing. - switch the parser to more sticks end tags \r\nXX\r\n - fix an issue in the waiting for response to break a special case where a spurious duplicate first character e.g. \r\r\nXX\r\n would not be detected as successful expected response. this happens e.g. if ATE0\r is sent while echo is enabled you will get ATE0\r\r\nXX\r\n
- optimise times - avoid issues when ruining from from task and with concurrent access when changing baud rate
registration callbacks and EPS status
Merge into release candidate
do not reallocate buffers in begin, but delete them in the destructor.
|
Wow Michael - this is huge... Thank you! We will study this and merge it as soon as possible. Thank you again, Tagging @nseidle - just so this pops up on his feed... |
Yes I am sorry about the size, maybe its better to start a new project [SparkFun_u-blox_Cellular_Arduino_Library] as my final goal is to support LARA-R6 in parallel to SARA-R5 and other SKUs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Paul, Nathan,
Attached you will find unfortunately a rather big PR to consider. I have added quite some functionality for my project that could be useful for others. If I wait longer, merging back it will just become even worse.
Do you think you could consider these changes, enhancements and improvements?
Sorry I have not yet good isolated examples that show the new functionality.