Skip to content

Bug fix for parsing of UBX-ESF-RAW packet #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Bug fix for parsing of UBX-ESF-RAW packet #33

wants to merge 2 commits into from

Conversation

nparker2020
Copy link
Contributor

This PR contains the fixed byte offset for parsing raw sensor data out of an incoming UBS-ESF-RAW packet.

@PaulZC
Copy link
Collaborator

PaulZC commented May 5, 2021

Hi Noah (@nparker2020 ),

Thank you for submitting this PR - nice catch!
Can you please do two things for me:

  • Please target the changes at the release_candidate branch so I can merge and test them without changing the master branch (instructions are here)
  • Please break this up into two commits: one containing the whitespace changes; and a second containing the actual code change. (Otherwise your change gets buried in white noise! ;-) )

Thanks again,
Paul

@PaulZC PaulZC linked an issue May 5, 2021 that may be closed by this pull request
[Bug] UBX-ESF-RAW message parsed incorrectly #32
Closed
@PaulZC PaulZC mentioned this pull request May 6, 2021
Closed
@PaulZC
Copy link
Collaborator

PaulZC commented May 7, 2021

Closing in favour of #35

@PaulZC PaulZC closed this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] UBX-ESF-RAW message parsed incorrectly
2 participants
@nparker2020 @PaulZC