Skip to content

UBX-NAV-TIMELS support added for leap second event #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 15, 2021
Merged

UBX-NAV-TIMELS support added for leap second event #25

merged 9 commits into from
Apr 15, 2021

Conversation

UT2UH
Copy link
Contributor

@UT2UH UT2UH commented Apr 14, 2021

Provides leap second event info as SNTP Leap Indicator, time to a leap second event and the number of leap seconds since GPS epoch for applications like NTP server.

@PaulZC
Copy link
Collaborator

PaulZC commented Apr 14, 2021

Hi @UT2UH ,
This PR looks really nice - thank you!
The only thing that jumps out is that the library has a new end function which deletes all of the RAM allocated for message storage. We will need to include the TIMELS storage in there too. You are not using callbacks - which is OK - so the code will look the same as moduleSWVersion and currentGeofenceParams. Can you please add it? Thanks!
Best wishes,
Paul

@UT2UH
Copy link
Contributor Author

UT2UH commented Apr 14, 2021

Hello @PaulZC ,
hope that is it.
Thanks and regards!

PaulZC
PaulZC reviewed Apr 15, 2021
View reviewed changes
PaulZC
PaulZC reviewed Apr 15, 2021
View reviewed changes
PaulZC
PaulZC reviewed Apr 15, 2021
View reviewed changes
PaulZC
PaulZC requested changes Apr 15, 2021
View reviewed changes
Copy link
Collaborator

@PaulZC PaulZC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @UT2UH ,
This is a really nice PR - thank you. You have followed the structure of the "auto" message code really well. I just have three comments (see above). Please take a look...
Thanks again,
Paul

@UT2UH
Copy link
Contributor Author

UT2UH commented Apr 15, 2021

Hi @PaulZC !
Yep, you are right, including on my mindless copycat issues too... Strange that it worked somehow... )
Thank you very much for the help and for the great library!

@PaulZC
Copy link
Collaborator

PaulZC commented Apr 15, 2021

Thanks @UT2UH ,
Good use of those two valid bits! ;-)
Merging...
Thanks again,
Paul

@PaulZC PaulZC merged commit b476796 into sparkfun:release_candidate Apr 15, 2021
UT2UH added a commit to UT2UH/SparkFun_u-blox_GNSS_Arduino_Library that referenced this pull request Apr 15, 2021
@UT2UH
Merge pull request #9 from sparkfun/release_candidate
f9b3760 
Merge pull request sparkfun#25 from UT2UH/release_candidate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulZC PaulZC PaulZC requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UT2UH @PaulZC