Skip to content

Add audio examples #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 13, 2023
Merged

Add audio examples #15

merged 9 commits into from
Dec 13, 2023

Conversation

sfe-SparkFro
Copy link
Collaborator

Brand new audio examples!

Don't merge yet, will be adding more examples soon! But please give it a look and let me know what you think, if this should be structured differently, etc. Thanks!

Allows us to use a single base class in audio examples instead of a specific module
Need to update name at some point as part of #9, it's not clear if UBX_CELL_VOICE or UBX_CELL_VOICE_BASE should be used based on the names alone
@sfe-SparkFro
Copy link
Collaborator Author

Ok, I think once #16 gets merged, this will be good to merge as well.

Any other examples we want to add here? I think these 3 examples demonstrate most of what people would need to do with regards to audio (ie. verify a speaker and microphone work, and handle phone calls), but happy to add more!

Copy link
Contributor

@PaulZC PaulZC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. If you've tested it on LARA, go ahead and merge it.

Serial.println(F("u-blox Cellular Audio Example 1 - Play Tone"));

Serial.println();
Serial.println(F("!!!!!!!! ATTENTION !!!!!!!! ATTENTION !!!!!!!! ATTENTION !!!!!!!!"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably don't need to worry about it any more, but there was a time when !!! would crash avrdude and prevent your code from uploading (onto AVR boards)...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, good catch! Doing some research, looks like the problem is actually the original bootloader on the ATMega2560. I agree that we probably don't need to worry about it (I can't any references to it within the last year in Google), but it's easy enough to change.

Just for the rare chance that someone is using the ATMega2560 with the original bootloader, triple exclamation marks would cause bad things. Easy enough to avoid by spacing them out!
@sfe-SparkFro sfe-SparkFro merged commit 6a73506 into v1.0.0 Dec 13, 2023
@sfe-SparkFro sfe-SparkFro deleted the add_audio_examples branch December 13, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants