This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Corrected the default maxWait values (for getPVT etc.) #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 26, 2019
Closed
|
Thanks for this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Nathan (@nseidle),
It was a great idea to make sure that maxWait was flowed down correctly from function to function.
The trouble is, the default maxWait for getLatitude, which calls getPVT, was then too short and resulted in timeouts. The default for getPVT was 1000msec, but that was getting overwritten by the 250msec default for getLatitude.
So, I've added a
#define getPVTmaxWaitof 1100msec (slightly longer than one navigation cycle) and have referenced that in getPVT, getLatitude, etc., etc..I've done the same thing for the getHPPOSLLH functions too.
getLatitude was missing
moduleQueried.all = false;so I've added that. (All the other associated functions include that line.)I've also added some extra debug prints to help monitor the time it takes for an ACK to be received.
Enjoy!
Paul