Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Added checksumFailurePin #61

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Added checksumFailurePin #61

merged 1 commit into from
Dec 27, 2019

Conversation

PaulZC
Copy link
Collaborator

@PaulZC PaulZC commented Dec 26, 2019

Hi Nathan (@nseidle),
Currently, processUBX uses Pin 2 to help diagnose checksum failures. This could cause problems for anyone using Pin 2 for other stuff - including SoftwareSerial in my case! ;-)
I suggest:

  • Adding checksumFailurePin to the header file.
  • Changing the digitalWrite in processUBX so it uses the checksumFailurePin (if defined) instead of having it hard-coded to Pin 2.

Instead of being const int, maybe checksumFailurePin should just be a regular int so it can be changed by the code in your .ino instead of involving editing the header file?
Or, you could really go to town on it and define a setChecksumFailurePin() function to change it?! But perhaps that's overkill...? ;-)
Enjoy!
Paul

@nseidle
Copy link
Member

nseidle commented Dec 27, 2019

Good catch. Yea, that was a vestige that I failed to remove. A like your new fix.

I don't think we need to expose it via a method. It's really only for debug.

@nseidle nseidle merged commit 99de3be into sparkfun:master Dec 27, 2019
@PaulZC PaulZC deleted the PaulZC_checksumFailurePin branch December 28, 2019 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants