This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Added checksumFailurePin #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Nathan (@nseidle),
Currently, processUBX uses Pin 2 to help diagnose checksum failures. This could cause problems for anyone using Pin 2 for other stuff - including SoftwareSerial in my case! ;-)
I suggest:
Instead of being
const int
, maybe checksumFailurePin should just be a regularint
so it can be changed by the code in your .ino instead of involving editing the header file?Or, you could really go to town on it and define a
setChecksumFailurePin()
function to change it?! But perhaps that's overkill...? ;-)Enjoy!
Paul