NAV-PVT : Automotive dead reckoning related parameters, Speed acc estimate and heading acc estimation parametes parsed. #159
Conversation
There was a problem hiding this comment.
Hi @balamuruganky ,
Looks good - thank you!
After one very small change, I'll happily merge this and test it. I now have NEO-M8U and ZED-F9R and can test it on those. (What I don't have is the time to test this properly in my car!)
Very best wishes,
Paul
| @@ -1029,6 +1029,7 @@ void SFE_UBLOX_GPS::processUBXpacket(ubxPacket *msg) | |||
| gnssFixOk = extractByte(21 - startingSpot) & 0x1; //Get the 1st bit | |||
| diffSoln = extractByte(21 - startingSpot) >> 1 & 0x1; //Get the 2nd bit | |||
| carrierSolution = extractByte(21 - startingSpot) >> 6; //Get 6th&7th bits of this byte | |||
| headVehValid = extractByte(21 - startingSpot) >> 5 & 0x1; // Get the 5th bit | |||
There was a problem hiding this comment.
Let's change this to:
headVehValid = (extractByte(21 - startingSpot) >> 5) & 0x1; // Get the 5th bit
just to make it clear that the shift happens before the AND
There was a problem hiding this comment.
Actually, can you change line 1030 too please?
(I know the code works - these changes just help with the clarity)
There was a problem hiding this comment.
Sure. I will update accordingly. Thanks.
Review comment incorporated.
|
Cool - thank you @balamuruganky ! Merging... |
|
Thank you!!! @PaulZC |
@nseidle, @PaulZC
NAV-PVT additional parameters parsed as listed below,
SpeedAccEst and HeadingAccEst Parameters are tested. Since, I don't have NEO-M8U or ZED-F9K, ADR related functionalies couldn't be tested. Please consider merging this PR, if ADR can be tested by some one else, those who have ADR GNSS.
Thanks.